Skip to content

Dev#16

Merged
llLeo306 merged 3 commits into
QDU-Robomaster:devfrom
Rui-Xiaoyu:dev
Mar 29, 2026
Merged

Dev#16
llLeo306 merged 3 commits into
QDU-Robomaster:devfrom
Rui-Xiaoyu:dev

Conversation

@Rui-Xiaoyu

@Rui-Xiaoyu Rui-Xiaoyu commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Enhancements:

  • Simplify the RLS class initialization by eliminating the Validate helper and associated configASSERT checks.

@sourcery-ai

sourcery-ai Bot commented Mar 29, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the constructor-time parameter validation step and its supporting private method from the RLS class, leaving only the Reset() initialization in the constructor.

Updated class diagram for RLS class without constructor validation

classDiagram
    class RLS {
        +RLS(dimension_ uint32_t, lambda_ float, delta_ float)
        +Reset()
        -dimension_ uint32_t
        -lambda_ float
        -delta_ float
        -defaultparamsvector_ ParamVector
    }
Loading

File-Level Changes

Change Details Files
Remove constructor-triggered parameter validation and the associated private Validate() method from the RLS class.
  • Stop calling the parameter validation routine in the RLS constructor, leaving only internal matrix initialization via Reset().
  • Delete the private Validate() helper method that asserted constraints on lambda_ and delta_.
  • Remove the inline configASSERT checks that enforced lambda_ in [0,1] and delta_ > 0.
RLS.hpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • By removing Validate() and its invocation in the constructor, the class no longer enforces basic parameter constraints; consider reintroducing validation (with the corrected condition lambda_ >= 0.0f && lambda_ <= 1.0f) or an equivalent runtime check to guard against invalid lambda_ and delta_ values.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- By removing `Validate()` and its invocation in the constructor, the class no longer enforces basic parameter constraints; consider reintroducing validation (with the corrected condition `lambda_ >= 0.0f && lambda_ <= 1.0f`) or an equivalent runtime check to guard against invalid `lambda_` and `delta_` values.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@llLeo306 llLeo306 merged commit 9f71f9b into QDU-Robomaster:dev Mar 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants